Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 15906010: Expose default constructors through ClassElement.localMembers. (Closed)

Created:
7 years, 6 months ago by ahe
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org, kasperl, karlklose
Visibility:
Public.

Description

Expose default constructors through ClassElement.localMembers. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=23891

Patch Set 1 #

Total comments: 3

Patch Set 2 : Ignore broken constructors in SDK libraries. #

Patch Set 3 : Address issues found during testing #

Patch Set 4 : Errors found during testing. #

Patch Set 5 : Merged with HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -9 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart View 1 chunk +15 lines, -6 lines 0 comments Download
M dart/tests/compiler/dart2js/type_checker_test.dart View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M dart/tests/lib/lib.status View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
A dart/tests/lib/mirrors/reflectively_instantiate_uninstantiated_class_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ahe
7 years, 6 months ago (2013-06-10 16:19:05 UTC) #1
ngeoffray
LGTM
7 years, 6 months ago (2013-06-11 08:44:25 UTC) #2
ahe
PTAL
7 years, 6 months ago (2013-06-11 13:15:09 UTC) #3
ahe
Bumping it up in your inboxes :-)
7 years, 6 months ago (2013-06-11 20:34:49 UTC) #4
ngeoffray
Still LGTM https://codereview.chromium.org/15906010/diff/1/dart/tests/lib/lib.status File dart/tests/lib/lib.status (right): https://codereview.chromium.org/15906010/diff/1/dart/tests/lib/lib.status#newcode35 dart/tests/lib/lib.status:35: [ $compiler == dart2js && $unchecked && ...
7 years, 6 months ago (2013-06-11 20:40:05 UTC) #5
ahe
https://codereview.chromium.org/15906010/diff/1/dart/tests/lib/lib.status File dart/tests/lib/lib.status (right): https://codereview.chromium.org/15906010/diff/1/dart/tests/lib/lib.status#newcode35 dart/tests/lib/lib.status:35: [ $compiler == dart2js && $unchecked && ($runtime == ...
7 years, 6 months ago (2013-06-11 20:45:42 UTC) #6
ngeoffray
https://codereview.chromium.org/15906010/diff/1/dart/tests/lib/lib.status File dart/tests/lib/lib.status (right): https://codereview.chromium.org/15906010/diff/1/dart/tests/lib/lib.status#newcode35 dart/tests/lib/lib.status:35: [ $compiler == dart2js && $unchecked && ($runtime == ...
7 years, 6 months ago (2013-06-11 20:55:09 UTC) #7
ahe
Committed patchset #5 manually as r23891 (presubmit successful).
7 years, 6 months ago (2013-06-12 06:38:11 UTC) #8
Johnni Winther
7 years, 6 months ago (2013-06-12 07:19:53 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698