Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 15904010: Fix issue 3874: non-deterministic AST generation caused by exceptions being thrown during parsing (… (Closed)

Created:
7 years, 6 months ago by srdjan
Modified:
7 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, hausner
Visibility:
Public.

Description

Fix issue 3874: non-deterministic AST generation caused by exceptions being thrown during parsing (StackOverFlow). Mark functions that throw and exception as non-optimizable. Fix flow graph printing (optimized vs non-optimized). R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=23350

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M runtime/vm/compiler.cc View 1 2 3 chunks +11 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
7 years, 6 months ago (2013-05-29 11:56:03 UTC) #1
Florian Schneider
lgtm https://codereview.chromium.org/15904010/diff/5001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/15904010/diff/5001/runtime/vm/parser.cc#newcode8121 runtime/vm/parser.cc:8121: // An exception may not occur in every ...
7 years, 6 months ago (2013-05-29 12:58:45 UTC) #2
srdjan
https://codereview.chromium.org/15904010/diff/5001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/15904010/diff/5001/runtime/vm/parser.cc#newcode8121 runtime/vm/parser.cc:8121: // An exception may not occur in every parse ...
7 years, 6 months ago (2013-05-29 13:01:29 UTC) #3
srdjan
7 years, 6 months ago (2013-05-29 13:07:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r23350 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698