Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 15904008: Add factory constructor to browser controller. (Closed)

Created:
7 years, 6 months ago by ricow1
Modified:
7 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add factory constructor to browser controller. Additionally, fix explicit number of browsers hack. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=23344

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M tools/testing/dart/browser_controller.dart View 2 chunks +15 lines, -10 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
7 years, 6 months ago (2013-05-29 10:44:45 UTC) #1
kustermann
lgtm
7 years, 6 months ago (2013-05-29 10:52:14 UTC) #2
ricow1
7 years, 6 months ago (2013-05-29 12:10:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r23344 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698