Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1589823004: Support messages in assert(). (Closed)

Created:
4 years, 11 months ago by Bob Nystrom
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry, kevmoo
CC:
reviews_dartlang.org, Paul Berry
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -26 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/argument_list_visitor.dart View 9 chunks +52 lines, -22 lines 0 comments Download
M lib/src/source_visitor.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M test/splitting/statements.stmt View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bob Nystrom
4 years, 11 months ago (2016-01-14 23:09:53 UTC) #2
Paul Berry
lgtm
4 years, 11 months ago (2016-01-14 23:20:52 UTC) #4
kevmoo
lgtm
4 years, 11 months ago (2016-01-14 23:50:09 UTC) #5
Bob Nystrom
4 years, 11 months ago (2016-01-14 23:51:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06657294ecc802ebed6230929247569e77b92561 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698