Issue 15888009: Fix http://dartbug.com/8669 by making sure we do not crash when trying to use Object as a mixin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15888009: Fix http://dartbug.com/8669 by making sure we do not crash when trying to use Object as a mixin. (Closed)

Created:
7 years, 6 months ago by kasperl

Modified:
7 years, 6 months ago

Reviewers:
Johnni Winther, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix http://dartbug.com/8669 by making sure we do not crash when trying to use Object as a mixin. R=johnniwinther@google.com, ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23384

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -12 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	3 chunks	+13 lines, -5 lines	2 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	tests/language/mixin_illegal_object_test.dart	View	1 chunk	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/15888009/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/15888009/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode111 sdk/lib/_internal/compiler/implementation/resolution/members.dart:111: // and we arbitrarily choose which ones. Thank ...

7 years, 6 months ago (2013-05-30 06:53:01 UTC) #2

kasperl

7 years, 6 months ago (2013-05-30 07:21:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r23384 (presubmit successful).

Expand Messages | Collapse Messages