Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 158833005: Use reasonable defaults for docgen if invoked on a single package (Closed)

Created:
6 years, 10 months ago by Alan Knight
Modified:
6 years, 10 months ago
Reviewers:
dgrove, Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use reasonable defaults for docgen if invoked on a single package BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=32583

Patch Set 1 #

Patch Set 2 : Make options just default the right way. Fix startPage -> start-page #

Total comments: 2

Patch Set 3 : Simplified #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -25 lines) Patch
M pkg/docgen/bin/docgen.dart View 1 2 4 chunks +56 lines, -22 lines 0 comments Download
M pkg/docgen/lib/docgen.dart View 1 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alan Knight
6 years, 10 months ago (2014-02-11 21:48:14 UTC) #1
Emily Fortuna
https://codereview.chromium.org/158833005/diff/10001/pkg/docgen/bin/docgen.dart File pkg/docgen/bin/docgen.dart (right): https://codereview.chromium.org/158833005/diff/10001/pkg/docgen/bin/docgen.dart#newcode25 pkg/docgen/bin/docgen.dart:25: String get _defaultStartPage { nit: I'd put this function ...
6 years, 10 months ago (2014-02-11 22:35:32 UTC) #2
Alan Knight
The logic was more complicated than it needed to be now that we're only really ...
6 years, 10 months ago (2014-02-11 23:01:55 UTC) #3
Emily Fortuna
lgtm!
6 years, 10 months ago (2014-02-11 23:44:06 UTC) #4
Alan Knight
6 years, 10 months ago (2014-02-11 23:45:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r32583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698