Issue 158773002: Change RawSocket.secureServer and RawSoccket.secure to fail on paused subscriptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 158773002: Change RawSocket.secureServer and RawSoccket.secure to fail on paused subscriptions (Closed)

Created:
6 years, 10 months ago by Søren Gjesse

Modified:
6 years, 10 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change RawSocket.secureServer and RawSoccket.secure to fail on paused subscriptions R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=32499

Patch Set 2 : Changed to make paused subscriptions an error #

Total comments: 1

Patch Set 3 : Addressed review comments #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -7 lines)			Patch
	M	sdk/lib/io/secure_socket.dart	View	1	3 chunks	+13 lines, -7 lines	0 comments	Download
	M	tests/standalone/io/raw_secure_server_socket_test.dart	View	1 2	2 chunks	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

This should be tightened up, and "takes over subscription" changed, as per offline discussion.

6 years, 10 months ago (2014-02-10 12:09:31 UTC) #2

Søren Gjesse

PTAL Changed to semantics to fail on paused subscriptions. Added a test for that.

6 years, 10 months ago (2014-02-10 12:27:19 UTC) #3

Bill Hesse

lgtm https://codereview.chromium.org/158773002/diff/50001/tests/standalone/io/raw_secure_server_socket_test.dart File tests/standalone/io/raw_secure_server_socket_test.dart (right): https://codereview.chromium.org/158773002/diff/50001/tests/standalone/io/raw_secure_server_socket_test.dart#newcode476 tests/standalone/io/raw_secure_server_socket_test.dart:476: asyncStart(); Maybe bool expectFail = pausedServer || pausedClient?

6 years, 10 months ago (2014-02-10 12:50:13 UTC) #4