Issue 158733003: Fix language tests wrt. warnings.

Issue 158733003: Fix language tests wrt. warnings. (Closed)

Created:
6 years, 10 months ago by Johnni Winther

Modified:
6 years, 10 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org, Brian Wilkerson

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix language tests wrt. warnings. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=32689 Committed: https://code.google.com/p/dart/source/detail?r=32691

Patch Set 2 : Fix tests and status. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -246 lines)			Patch
M	tests/language/abstract_exact_selector_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/language/abstract_factory_constructor_test.dart	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	tests/language/abstract_getter_test.dart	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	tests/language/abstract_runtime_error_test.dart	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	tests/language/assign_top_method_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/bad_named_parameters2_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/bad_named_parameters_test.dart	View		1 chunk	+10 lines, -10 lines	0 comments	Download
M	tests/language/bit_operations_test.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	tests/language/call_constructor_on_unresolvable_class_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/language/call_nonexistent_constructor_test.dart	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	tests/language/checked_null_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/language/checked_setter2_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/language/checked_setter3_test.dart	View		1 chunk	+10 lines, -8 lines	0 comments	Download
M	tests/language/checked_setter_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/language/class_literal_test.dart	View		2 chunks	+28 lines, -28 lines	0 comments	Download
M	tests/language/closure_type_test.dart	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	tests/language/compile_time_constant_k_test.dart	View	1	2 chunks	+10 lines, -6 lines	0 comments	Download
M	tests/language/compile_time_constant_o_test.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	tests/language/const_objects_are_immutable_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/constructor_named_arguments_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/constructor_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/language/core_type_check_test.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A +	tests/language/crash_6725_part.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/language/crash_6725_test.dart	View		1 chunk	+3 lines, -61 lines	0 comments	Download
M	tests/language/default_factory_library_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/default_factory_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/language/double_to_string_as_exponential2_test.dart	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	tests/language/double_to_string_as_fixed2_test.dart	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	tests/language/double_to_string_as_precision2_test.dart	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	tests/language/dynamic_field_test.dart	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/language/dynamic_prefix_core_test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language_analyzer.status	View	1	4 chunks	+9 lines, -30 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1	4 chunks	+9 lines, -30 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/158733003/diff/1/tests/language/abstract_getter_test.dart File tests/language/abstract_getter_test.dart (right): https://codereview.chromium.org/158733003/diff/1/tests/language/abstract_getter_test.dart#newcode11 tests/language/abstract_getter_test.dart:11: get i; /// 01: static type warning I ...

6 years, 10 months ago (2014-02-13 14:01:41 UTC) #2

Johnni Winther

Committed patchset #1 manually as r32689 (presubmit successful).

6 years, 10 months ago (2014-02-14 09:36:19 UTC) #3

Johnni Winther

https://codereview.chromium.org/158733003/diff/1/tests/language/abstract_getter_test.dart File tests/language/abstract_getter_test.dart (right): https://codereview.chromium.org/158733003/diff/1/tests/language/abstract_getter_test.dart#newcode11 tests/language/abstract_getter_test.dart:11: get i; /// 01: static type warning On 2014/02/13 ...

6 years, 10 months ago (2014-02-14 09:46:47 UTC) #4

Johnni Winther

6 years, 10 months ago (2014-02-14 12:00:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r32691 (presubmit successful).

Expand Messages | Collapse Messages