Add packages as a dependency for dart2js target

Add packages as a dependency for dart2js target

Since dartdoc depeneds on packages and we include it in the snapshot we need packages as a depenedency.

Currently tools/build.py -mrelease dart2js is broken if you do a clean build.

R=ahe@google.com, kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23804

[kustermann, 2013-06-06 09:56:11]

https://codereview.chromium.org/15870012/diff/1/utils/compiler/compiler.gyp
File utils/compiler/compiler.gyp (right):

https://codereview.chromium.org/15870012/diff/1/utils/compiler/compiler.gyp#n...
utils/compiler/compiler.gyp:15: '../../pkg/pkg.gyp:pkg_packages',
Shouldn't we add this to dart.gyp? i.e.
115     {
116       'target_name': 'dart2js',
117       'type': 'none',
118       'dependencies': [
119         'utils/compiler/compiler.gyp:dart2js',
+++         'packages',
120       ],
121     },

[ahe, 2013-06-06 09:56:32]

https://codereview.chromium.org/15870012/diff/1/utils/compiler/compiler.gyp
File utils/compiler/compiler.gyp (right):

https://codereview.chromium.org/15870012/diff/1/utils/compiler/compiler.gyp#n...
utils/compiler/compiler.gyp:15: '../../pkg/pkg.gyp:pkg_packages',
You need to modify inputs below as well.

[ricow1, 2013-06-06 14:51:38]

Added a timestamp file for the packages target, using this as input to the
dart2js target

https://codereview.chromium.org/15870012/diff/1/utils/compiler/compiler.gyp
File utils/compiler/compiler.gyp (right):

https://codereview.chromium.org/15870012/diff/1/utils/compiler/compiler.gyp#n...
utils/compiler/compiler.gyp:15: '../../pkg/pkg.gyp:pkg_packages',
On 2013/06/06 09:56:11, kustermann wrote:
> Shouldn't we add this to dart.gyp? i.e.
> 115     {
> 116       'target_name': 'dart2js',
> 117       'type': 'none',
> 118       'dependencies': [
> 119         'utils/compiler/compiler.gyp:dart2js',
> +++         'packages',
> 120       ],
> 121     },
That will not work as discussed offline

https://codereview.chromium.org/15870012/diff/1/utils/compiler/compiler.gyp#n...
utils/compiler/compiler.gyp:15: '../../pkg/pkg.gyp:pkg_packages',
On 2013/06/06 09:56:32, ahe wrote:
> You need to modify inputs below as well.

Done

[kustermann, 2013-06-06 15:23:49]

lgtm, but wait for peter's comments.

https://codereview.chromium.org/15870012/diff/4001/tools/create_timestamp_fil...
File tools/create_timestamp_file.py (right):

https://codereview.chromium.org/15870012/diff/4001/tools/create_timestamp_fil...
tools/create_timestamp_file.py:15: if __name__ == '__main__':
We've already 'editor/build/truncate_files.py' to do this. I think  you should
reuse that.

[ricow1, 2013-06-06 17:17:30]

https://codereview.chromium.org/15870012/diff/4001/tools/create_timestamp_fil...
File tools/create_timestamp_file.py (right):

https://codereview.chromium.org/15870012/diff/4001/tools/create_timestamp_fil...
tools/create_timestamp_file.py:15: if __name__ == '__main__':
On 2013/06/06 15:23:49, kustermann wrote:
> We've already 'editor/build/truncate_files.py' to do this. I think  you should
> reuse that.
Removed file and added timestamp functionality to the make_links file instead

[ahe, 2013-06-07 10:08:32]

LGTM!

[ricow1, 2013-06-10 11:57:15]

Committed patchset #4 manually as r23804 (presubmit successful).