Issue 158693002: Remove the embedded license copy in tarball creation script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 158693002: Remove the embedded license copy in tarball creation script (Closed)

Created:
6 years, 10 months ago by Søren Gjesse

Modified:
6 years, 10 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove the embedded license copy in tarball creation script R=ricow@google.com BUG=http://dartbug.com/16582 Committed: https://code.google.com/p/dart/source/detail?r=32486

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -64 lines)			Patch
	M	tools/create_tarball.py	View		2 chunks	+2 lines, -64 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

lgtm https://codereview.chromium.org/158693002/diff/1/tools/create_tarball.py File tools/create_tarball.py (right): https://codereview.chromium.org/158693002/diff/1/tools/create_tarball.py#newcode82 tools/create_tarball.py:82: license_lines = lf.read().splitlines() lf.readlines()

6 years, 10 months ago (2014-02-10 08:23:11 UTC) #2

Søren Gjesse

https://codereview.chromium.org/158693002/diff/1/tools/create_tarball.py File tools/create_tarball.py (right): https://codereview.chromium.org/158693002/diff/1/tools/create_tarball.py#newcode82 tools/create_tarball.py:82: license_lines = lf.read().splitlines() On 2014/02/10 08:23:11, ricow1 wrote: > ...

6 years, 10 months ago (2014-02-10 08:36:15 UTC) #3

Søren Gjesse

6 years, 10 months ago (2014-02-10 08:49:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r32486 (presubmit successful).

Expand Messages | Collapse Messages