Issue 15868003: Revert "Rewrite double.parse."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15868003: Revert "Rewrite double.parse." (Closed)

Created:
7 years, 7 months ago by floitsch

Modified:
7 years, 7 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Rewrite double.parse." This reverts commit r23062. Committed: https://code.google.com/p/dart/source/detail?r=23065

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+183 lines, -273 lines)			Patch
M	runtime/lib/double.cc	View	1 chunk	+80 lines, -14 lines	0 comments	Download
M	runtime/lib/double_patch.dart	View	1 chunk	+5 lines, -35 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 chunk	+0 lines, -58 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	1 chunk	+5 lines, -9 lines	0 comments	Download
M	sdk/lib/core/double.dart	View	1 chunk	+7 lines, -23 lines	0 comments	Download
M	tests/corelib/string_trim2_test.dart	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	tests/lib/math/math_parse_double_test.dart	View	2 chunks	+81 lines, -128 lines	0 comments	Download

Total messages: 3 (0 generated)

floitsch

looks like a bug in the test case. Reverting until fixed.

7 years, 7 months ago (2013-05-23 12:59:40 UTC) #1

floitsch

7 years, 7 months ago (2013-05-23 13:00:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23065 (presubmit successful).