Add zone support to streams.

Add zone support to streams.

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24036

[Lasse Reichstein Nielsen, 2013-05-29 08:32:26]

lgtm

Only form comments, no content.

https://codereview.chromium.org/15864007/diff/3027/sdk/lib/async/stream_impl....
File sdk/lib/async/stream_impl.dart (right):

https://codereview.chromium.org/15864007/diff/3027/sdk/lib/async/stream_impl....
sdk/lib/async/stream_impl.dart:224: _zone.unexpectCallback();
Hmm, seeing it like this: unexpect is not a verb. It's stopExpecting, or
dontExpect.
Or other antonyms of expect: abandon, forfeit, forfend, shun :)

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors15_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors15_test.dart:28: onDone: () => events.add("inner
done"));
Indent to '(' - i.e., 5 more.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors16_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors16_test.dart:27: Expect.listEquals([
This looks weird. It should be indented 2 relative to onDone.

And remove space between [ and ".

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors17_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors17_test.dart:11: // time out if the callbacks are
not invoked.
will be timed out

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors17_test.dart:36: Expect.listEquals([
Indent to 2 beyond start of onDone.
Space between [ and ".

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors18_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors18_test.dart:30: 0, 1, 2, 3, 4,
Indent of list content is just wrong.
Move all to previous line?

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors19_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors19_test.dart:30: 0, 1, 2, 3, 4,
On one line?

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors20_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors20_test.dart:28: 499,
Indent?

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors22_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors22_test.dart:33: "caught: 1",
Just wrong :)

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors24_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors24_test.dart:44: Expect.listEquals([
Indent to 2 after onDone starts.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors24_test.dart:51: ],
Unindent by 1.

[floitsch, 2013-05-29 15:48:56]

https://codereview.chromium.org/15864007/diff/3027/sdk/lib/async/stream_impl....
File sdk/lib/async/stream_impl.dart (right):

https://codereview.chromium.org/15864007/diff/3027/sdk/lib/async/stream_impl....
sdk/lib/async/stream_impl.dart:224: _zone.unexpectCallback();
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> Hmm, seeing it like this: unexpect is not a verb. It's stopExpecting, or
> dontExpect.
> Or other antonyms of expect: abandon, forfeit, forfend, shun :)

cancelCallbackExpectation

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors15_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors15_test.dart:28: onDone: () => events.add("inner
done"));
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> Indent to '(' - i.e., 5 more.

Done.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors16_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors16_test.dart:27: Expect.listEquals([
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> This looks weird. It should be indented 2 relative to onDone.
> 
> And remove space between [ and ".

done.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors17_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors17_test.dart:11: // time out if the callbacks are
not invoked.
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> will be timed out

Changed for all tests to:
  // We keep a ReceivePort open until all tests are done. This way the VM will
  // hang if the callbacks are not invoked and the test will time out.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors17_test.dart:36: Expect.listEquals([
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> Indent to 2 beyond start of onDone.
> Space between [ and ".

Done.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors18_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors18_test.dart:30: 0, 1, 2, 3, 4,
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> Indent of list content is just wrong.
> Move all to previous line?

Done.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors19_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors19_test.dart:30: 0, 1, 2, 3, 4,
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> On one line?

Done.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors20_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors20_test.dart:28: 499,
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> Indent?
changed like in other tests.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors22_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors22_test.dart:33: "caught: 1",
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> Just wrong :)

Done.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
File tests/lib/async/catch_errors24_test.dart (right):

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors24_test.dart:44: Expect.listEquals([
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> Indent to 2 after onDone starts.

Done.

https://codereview.chromium.org/15864007/diff/3027/tests/lib/async/catch_erro...
tests/lib/async/catch_errors24_test.dart:51: ],
On 2013/05/29 08:32:26, Lasse Reichstein Nielsen wrote:
> Unindent by 1.

Done.

[floitsch, 2013-06-12 14:21:55]

PTAL. rebased and rewrote some Zones to take callbacks instead of providing
streams.

[Lasse Reichstein Nielsen, 2013-06-13 11:58:47]

lgtm

https://codereview.chromium.org/15864007/diff/17001/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/15864007/diff/17001/sdk/lib/async/zone.dart#n...
sdk/lib/async/zone.dart:196: _runUnguarded(fun);
That sounds like you could just have run fun directly,
Maybe write this._runUnguarded, to emphasize that it is the zone running it.

https://codereview.chromium.org/15864007/diff/17001/sdk/lib/async/zone.dart#n...
sdk/lib/async/zone.dart:239: _isExecutingCallback = true;
So you can have nested callbacks?

https://codereview.chromium.org/15864007/diff/17001/sdk/lib/async/zone.dart#n...
sdk/lib/async/zone.dart:242: } catch(e, s) {
Seems overkill to catch and rethrow, but I guess it won't happen often.

https://codereview.chromium.org/15864007/diff/17001/tests/lib/async/catch_err...
File tests/lib/async/catch_errors15_test.dart (right):

https://codereview.chromium.org/15864007/diff/17001/tests/lib/async/catch_err...
tests/lib/async/catch_errors15_test.dart:36: "catch error entry2",
Space is off-by-one.

[floitsch, 2013-06-13 13:36:51]

https://codereview.chromium.org/15864007/diff/17001/sdk/lib/async/zone.dart
File sdk/lib/async/zone.dart (right):

https://codereview.chromium.org/15864007/diff/17001/sdk/lib/async/zone.dart#n...
sdk/lib/async/zone.dart:196: _runUnguarded(fun);
On 2013/06/13 11:58:47, Lasse Reichstein Nielsen wrote:
> That sounds like you could just have run fun directly,
> Maybe write this._runUnguarded, to emphasize that it is the zone running it.

Done.

https://codereview.chromium.org/15864007/diff/17001/sdk/lib/async/zone.dart#n...
sdk/lib/async/zone.dart:239: _isExecutingCallback = true;
On 2013/06/13 11:58:47, Lasse Reichstein Nielsen wrote:
> So you can have nested callbacks?

yes. For example a future-callback can invoke a sync-completer (which then has a
chain of futures).

https://codereview.chromium.org/15864007/diff/17001/sdk/lib/async/zone.dart#n...
sdk/lib/async/zone.dart:242: } catch(e, s) {
On 2013/06/13 11:58:47, Lasse Reichstein Nielsen wrote:
> Seems overkill to catch and rethrow, but I guess it won't happen often.

Otherwise I would need to duplicate the try/catch. Can be changed if it turns
out to be too expensive.

https://codereview.chromium.org/15864007/diff/17001/tests/lib/async/catch_err...
File tests/lib/async/catch_errors15_test.dart (right):

https://codereview.chromium.org/15864007/diff/17001/tests/lib/async/catch_err...
tests/lib/async/catch_errors15_test.dart:36: "catch error entry2",
On 2013/06/13 11:58:47, Lasse Reichstein Nielsen wrote:
> Space is off-by-one.

Done.

[floitsch, 2013-06-14 16:28:52]

Committed patchset #8 manually as r24036 (presubmit successful).