Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 15861016: Don't use statically declared Mutex in debugger (Closed)

Created:
7 years, 7 months ago by hausner
Modified:
7 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't use statically declared Mutex in debugger Hopefully eliminates the "resource busy" errors we occasionally see on MacOS (issue 10488). I ran the debugger test 10000 times in a loop on my machine and never ran into the assert. Let's hope the build bot is happy too. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=23178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M runtime/bin/dbg_message.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_message.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 7 months ago (2013-05-24 20:11:24 UTC) #1
siva
lgtm
7 years, 7 months ago (2013-05-24 20:13:10 UTC) #2
hausner
7 years, 7 months ago (2013-05-24 20:35:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698