Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 15861004: Temporary, only escape quotes if run in shell. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen
Modified:
7 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Temporary, only escape quotes if run in shell. This gets pub to pass. This patch should be reverted at some point. BUG= Committed: https://code.google.com/p/dart/source/detail?r=23150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M runtime/bin/process_patch.dart View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
TBR
7 years, 7 months ago (2013-05-24 14:14:09 UTC) #1
Anders Johnsen
Committed patchset #1 manually as r23150 (presubmit successful).
7 years, 7 months ago (2013-05-24 14:14:58 UTC) #2
Søren Gjesse
lgtm
7 years, 7 months ago (2013-05-27 14:21:07 UTC) #3
Søren Gjesse
7 years, 7 months ago (2013-05-27 14:21:45 UTC) #4
Message was sent while issue was closed.
On 2013/05/27 14:21:07, Søren Gjesse wrote:
> lgtm

We should open an issue on this and change the TODO to the issue number.

Powered by Google App Engine
This is Rietveld 408576698