Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1585513002: Get rid of all the library tags. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
Bob Nystrom, kasperl
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -688 lines) Patch
M lib/src/ascii_tree.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/asset/dart/serialize.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/asset/dart/serialize/aggregate_transform.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/asset/dart/serialize/exception.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/asset/dart/serialize/get_input_transform.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/asset/dart/serialize/transform.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/asset/dart/serialize/transformer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/asset/dart/transformer_isolate.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/asset/dart/utils.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/admin_server.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/asset_environment.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/barback_server.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/base_server.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/cycle_exception.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/dart2js_transformer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/dart_forwarding_transformer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/dependency_computer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/excluding_aggregate_transformer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/excluding_transformer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/foreign_transformer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/load_all_transformers.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/pub_package_provider.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/source_directory.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/transformer_cache.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/transformer_config.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/transformer_id.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/transformer_isolate.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/transformer_loader.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/barback/web_socket_api.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/cached_package.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/barback.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/build.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/cache.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/cache_add.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/cache_list.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/cache_repair.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/deps.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/downgrade.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/get.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/global.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/global_activate.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/global_deactivate.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/global_list.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/global_run.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/lish.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/list_package_dirs.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/run.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/serve.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/upgrade.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/uploader.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command/version.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/command_runner.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/dart.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/entrypoint.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/error_group.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/exceptions.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/executable.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/exit_codes.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/git.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/global_packages.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/http.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/io.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/lock_file.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/log.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/oauth2.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/package.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/package_graph.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/preprocess.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/progress.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/pubspec.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/sdk.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/solver/backtracking_solver.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/solver/solve_report.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/solver/unselected_package_queue.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/solver/version_queue.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/solver/version_selection.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/solver/version_solver.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/source.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/source/cached.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/source/git.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/source/hosted.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/source/path.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/source/unknown.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/source_registry.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/system_cache.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/transcript.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/compiled_dartdoc.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/dependency.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/dependency_override.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/directory.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/executable.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/license.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/name.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/pubspec.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/pubspec_field.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/sdk_constraint.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/size.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/validator/utf8_readme.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/ascii_tree_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/build/allows_arbitrary_modes_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/build/can_specify_output_directory_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/build/defaults_to_release_mode_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/add/adds_latest_matching_version_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/add/adds_latest_version_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/add/all_adds_all_matching_versions_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/add/all_with_some_versions_present_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/add/already_cached_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/add/bad_version_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/add/missing_package_arg_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/add/no_matching_version_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/add/package_not_found_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/add/unexpected_arguments_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/list_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/repair/empty_cache_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/repair/handles_corrupted_binstub_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/repair/handles_corrupted_global_lockfile_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/repair/handles_failure_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/repair/handles_orphaned_binstub_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/repair/recompiles_snapshots_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/repair/reinstalls_git_packages_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/repair/reinstalls_hosted_packages_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cache/repair/updates_binstubs_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dart2js/allows_import_in_dart_code_test.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M test/dart2js/compiles_generated_file_from_dependency_outside_web_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dart2js/compiles_generated_file_from_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dart2js/compiles_imported_generated_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dart2js/outputs_deferred_libraries_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M test/dependency_computer/conservative_dependencies_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dependency_computer/cycle_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dependency_computer/dev_transformers_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dependency_computer/error_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dependency_computer/import_dependencies_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dependency_computer/no_dependencies_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dependency_computer/transformers_needed_by_library_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/dependency_computer/utils.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/descriptor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/descriptor/git.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/descriptor/packages.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/descriptor/tar.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/downgrade/does_not_show_other_versions_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/downgrade/unlock_dependers_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/downgrade/unlock_if_necessary_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/error_group_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/broken_symlink_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/cache_transformed_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/check_out_and_upgrade_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/check_out_branch_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/check_out_revision_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/check_out_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/check_out_transitive_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/check_out_twice_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/check_out_unfetched_revision_of_cached_repo_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/check_out_with_trailing_slash_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/dependency_name_match_pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/different_repo_name_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/doesnt_fetch_if_nothing_changes_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/lock_version_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/locked_revision_without_repo_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/require_pubspec_name_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/require_pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/stay_locked_if_compatible_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/git/unlock_if_incompatible_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/avoid_network_requests_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/cached_pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/do_not_upgrade_on_removed_constraints_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/does_no_network_requests_when_possible_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/get_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/get_transitive_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/gets_a_package_with_busted_dev_dependencies_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/resolve_constraints_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/stay_locked_if_compatible_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/stay_locked_if_new_is_satisfied_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/stay_locked_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/unlock_if_incompatible_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/unlock_if_new_is_unsatisfied_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/hosted/unlock_if_version_doesnt_exist_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/relative_symlink_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/get/switch_source_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/hosted/fail_gracefully_on_url_resolve_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/hosted/offline_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/hosted/remove_removed_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/hosted/remove_removed_transitive_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/hosted/version_negotiation_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/io_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/lish/utils.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/lock_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/oauth2/utils.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/package_list_files_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/preprocess_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/pub_get_and_upgrade_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/pub_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/pub_uploader_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/real_version_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/404_page_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/allows_arbitrary_modes_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/defaults_to_debug_mode_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/does_not_crash_if_an_unused_dart_file_has_a_syntax_error_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/does_not_serve_dart_in_release_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/does_not_serve_hidden_assets_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/does_not_watch_compiled_js_files_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/gets_first_if_dependency_added_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/gets_first_if_dependency_is_not_installed_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/gets_first_if_dependency_version_changed_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/gets_first_if_dev_dependency_changed_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/gets_first_if_git_ref_changed_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/gets_first_if_git_url_changed_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/gets_first_if_no_lockfile_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/gets_first_if_path_dependency_changed_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/gets_first_if_source_changed_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/gets_first_if_transitive_dependency_is_not_installed_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/invalid_method_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/invalid_urls_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/missing_asset_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/missing_dependency_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/missing_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/native_watch_added_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/native_watch_modified_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/native_watch_removed_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/native_watch_replaced_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/serve_from_app_lib_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/serve_from_app_web_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/serve_from_dependency_lib_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/serves_file_with_space_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/serves_index_html_for_directories_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/serves_web_and_test_dirs_by_default_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/supports_cross_origin_header_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/supports_user_defined_declaring_transformers_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/supports_user_defined_lazy_transformers_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/unknown_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/uses_appropriate_mime_types_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/utils.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/watch_added_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/watch_modified_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/watch_removed_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/exit_on_close_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/path_to_urls_errors_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/path_to_urls_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/path_to_urls_with_line_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/serve_directory_already_served_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/serve_directory_and_immediately_request_asset_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/serve_directory_and_immediately_serve_again_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/serve_directory_and_immediately_unserve_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/serve_directory_arg_errors_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/serve_directory_overlapping_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/serve_directory_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/unserve_directory_arg_errors_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/unserve_directory_not_served_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/unserve_directory_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/url_to_asset_id_errors_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/url_to_asset_id_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve/web_socket/url_to_asset_id_with_line_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/serve_packages.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/creates_a_snapshot_for_immediate_and_transitive_dep_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/creates_a_snapshot_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/doesnt_load_irrelevant_transformers_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/doesnt_resnapshot_when_a_dependency_is_unchanged_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/doesnt_snapshot_an_entrypoint_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/doesnt_snapshot_path_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/doesnt_snapshot_transitive_dependencies_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/prints_errors_for_broken_snapshots_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/recompiles_if_the_sdk_is_out_of_date_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/snapshots_transformed_code_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/updates_snapshot_for_git_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/upgrades_snapshot_for_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/snapshot/upgrades_snapshot_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/test_pub.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transcript_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/a_transformer_rejects_its_config_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/asset_not_found_exceptions_are_detectable_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/cache_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/can_log_messages_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/can_use_consume_primary_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/can_use_has_input_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/can_use_read_input_as_string_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/can_use_read_input_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/configuration/configuration_defaults_to_empty_map_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/configuration/passes_configuration_to_a_transformer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/configuration/with_configuration_only_instantiates_configurable_transformers_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/dart2js_transformer_before_another_transformer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/does_not_run_a_transform_on_an_input_in_another_package_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/exclude_asset_glob_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/exclude_asset_list_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/exclude_asset_prefix_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/exclude_asset_string_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/include_asset_glob_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/include_asset_list_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/include_asset_prefix_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/include_asset_string_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/includes_before_excludes_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/works_on_aggregate_transformer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/works_on_dart2js_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/works_on_lazy_transformer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/exclusion/works_on_transformer_group_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/fails_to_load_a_file_that_defines_no_transforms_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/fails_to_load_a_non_existent_transform_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/fails_to_load_a_transform_from_a_deps_dev_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/fails_to_load_a_transform_from_a_non_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/fails_to_load_a_transform_with_a_syntax_error_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/fails_to_load_a_transform_with_an_import_error_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/fails_to_load_an_unconfigurable_transformer_when_config_is_passed_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/loads_a_declaring_aggregate_transformer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/loads_a_diamond_transformer_dependency_graph_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/loads_a_lazy_aggregate_transformer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/loads_a_transformer_defined_in_an_exported_library_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/loads_an_aggregate_transformer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/loads_different_configurations_from_the_same_isolate_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/multiple_transformers_reject_their_config_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/prefers_transformer_to_library_name_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/prints_a_transform_error_in_apply_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/prints_a_transform_interface_error_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/runs_a_local_transform_on_the_application_package_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/runs_a_third_party_transform_on_the_application_package_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/runs_a_third_party_transformer_on_a_local_transformer_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/runs_a_transformer_group_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/runs_a_transformer_on_a_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/runs_one_third_party_transformer_on_another_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/transformer/supports_a_transformer_that_doesnt_return_futures_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/unknown_source_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/git/do_not_upgrade_if_unneeded_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/git/upgrade_locked_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/git/upgrade_one_locked_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/git/upgrade_to_incompatible_pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/git/upgrade_to_nonexistent_pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/hosted/unlock_dependers_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/hosted/unlock_if_necessary_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/hosted/upgrade_removed_constraints_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/report/describes_change_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/report/does_not_show_newer_versions_for_locked_packages_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/report/highlights_overrides_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/report/leading_character_shows_change_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/report/shows_newer_available_versions_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/upgrade/report/shows_number_of_changed_dependencies_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/utils_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/validator/utils.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/version_solver_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nweiz
4 years, 11 months ago (2016-01-13 00:40:57 UTC) #1
Bob Nystrom
lgtm
4 years, 11 months ago (2016-01-13 01:19:38 UTC) #2
nweiz
Committed patchset #1 (id:1) manually as 31c48c9701ef88d5202e599a85a1402614363c10 (presubmit successful).
4 years, 11 months ago (2016-01-13 01:24:39 UTC) #4
kasperl
I don't understand why this is a good change. I understand that some people don't ...
4 years, 11 months ago (2016-01-13 07:33:28 UTC) #6
Bob Nystrom
4 years, 11 months ago (2016-01-13 17:11:51 UTC) #7
Message was sent while issue was closed.
On 2016/01/13 07:33:28, kasperl wrote:
> I don't understand why this is a good change. I understand that some people
> don't want to write the library tag, but it does add value to have it

It's just more boilerplate code to maintain and to worry that it will get out of
sync with the file name.

> particular for people doing reflection.

That's a relatively uncommon use case and I think even there users would rather
identify libraries by URL instead of name.

– bob

Powered by Google App Engine
This is Rietveld 408576698