Implementation of CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE error code.

Implementation of CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE error code.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23440

[scheglov, 2013-05-30 18:34:41]

https://codereview.chromium.org/15855005/diff/6001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/15855005/diff/6001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:3039:
// If this is not the first time this method is being called, (stack.size() !=
1) and the
What "stack"?

https://codereview.chromium.org/15855005/diff/6001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
(right):

https://codereview.chromium.org/15855005/diff/6001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:2542:

Do we want to report problem for this?

class A implements B {}
class B extends A {}

[jwren, 2013-05-30 18:55:19]

https://codereview.chromium.org/15855005/diff/6001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/15855005/diff/6001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:3039:
// If this is not the first time this method is being called, (stack.size() !=
1) and the
Fixing, refactoring didn't update the comment stack -> list.

https://codereview.chromium.org/15855005/diff/6001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
(right):

https://codereview.chromium.org/15855005/diff/6001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:2542:

I think we want to, and as I was wrapping up this CL I noticed tests in the co19
and language tests that indicate that that your example should be an error too. 
Updating our errors set to include the error code for this case (and the code to
check for it), are on my list.

On 2013/05/30 18:34:41, scheglov wrote:
> Do we want to report problem for this?
> 
> class A implements B {}
> class B extends A {}

[Brian Wilkerson, 2013-05-30 19:39:54]

LGTM

[scheglov, 2013-05-30 19:41:37]

lgtm

[jwren, 2013-05-30 20:06:35]

Committed patchset #7 manually as r23440 (presubmit successful).