Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 15854003: Fix some bugs in the Uri class (Closed)

Created:
7 years, 6 months ago by Søren Gjesse
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix some bugs in the Uri class The queryParameters key was not decoded if there was no = sign after it. The normalization skipped any normal characters after the last encoded character. R=lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23533

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M sdk/lib/core/uri.dart View 1 3 chunks +12 lines, -10 lines 0 comments Download
M tests/corelib/uri_query_test.dart View 3 chunks +28 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 6 months ago (2013-05-30 15:58:58 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/15854003/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/15854003/diff/1/sdk/lib/core/uri.dart#newcode315 sdk/lib/core/uri.dart:315: fillResult() { void return type. Makes it more ...
7 years, 6 months ago (2013-06-03 07:56:47 UTC) #2
Søren Gjesse
https://codereview.chromium.org/15854003/diff/1/sdk/lib/core/uri.dart File sdk/lib/core/uri.dart (right): https://codereview.chromium.org/15854003/diff/1/sdk/lib/core/uri.dart#newcode315 sdk/lib/core/uri.dart:315: fillResult() { On 2013/06/03 07:56:47, Lasse Reichstein Nielsen wrote: ...
7 years, 6 months ago (2013-06-03 09:35:41 UTC) #3
Søren Gjesse
7 years, 6 months ago (2013-06-03 09:37:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23533 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698