Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 15854002: Make sure the type arguments of the supertype of a class are being added to the isCheck set. That s… (Closed)

Created:
7 years, 7 months ago by ngeoffray
Modified:
7 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make sure the type arguments of the supertype of a class are being added to the isCheck set. That supertype may not be instantiated. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=23058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -14 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 2 chunks +21 lines, -14 lines 0 comments Download
A tests/language/type_argument_in_super_type_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 7 months ago (2013-05-23 09:54:52 UTC) #1
karlklose
LGTM.
7 years, 7 months ago (2013-05-23 10:48:14 UTC) #2
ngeoffray
7 years, 7 months ago (2013-05-23 10:49:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23058 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698