Issue 15853005: Change the cmd-line output for warnings from foo.dart:line:col to foo.dart, line x, col y.

Issue 15853005: Change the cmd-line output for warnings from foo.dart:line:col to foo.dart, line x, col y. (Closed)

Created:
7 years, 6 months ago by devoncarew

Modified:
7 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Change the cmd-line output for warnings from foo.dart:line:col to foo.dart, line x, col y. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=23422

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -14 lines)			Patch
	M	editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/ErrorFormatter.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	pkg/analyzer_experimental/lib/src/error_formatter.dart	View	1	1 chunk	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

lgtm https://codereview.chromium.org/15853005/diff/1/pkg/analyzer_experimental/lib/src/error_formatter.dart File pkg/analyzer_experimental/lib/src/error_formatter.dart (right): https://codereview.chromium.org/15853005/diff/1/pkg/analyzer_experimental/lib/src/error_formatter.dart#newcode127 pkg/analyzer_experimental/lib/src/error_formatter.dart:127: // [warning] 'foo' is not a method or ...

7 years, 6 months ago (2013-05-30 16:20:57 UTC) #2

devoncarew

https://codereview.chromium.org/15853005/diff/1/pkg/analyzer_experimental/lib/src/error_formatter.dart File pkg/analyzer_experimental/lib/src/error_formatter.dart (right): https://codereview.chromium.org/15853005/diff/1/pkg/analyzer_experimental/lib/src/error_formatter.dart#newcode127 pkg/analyzer_experimental/lib/src/error_formatter.dart:127: // [warning] 'foo' is not a method or function ...

7 years, 6 months ago (2013-05-30 16:24:50 UTC) #3

devoncarew

7 years, 6 months ago (2013-05-30 16:25:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r23422 (presubmit successful).

Expand Messages | Collapse Messages