Issue 15850004: Verify that correct number of arguments was passed.

Issue 15850004: Verify that correct number of arguments was passed. (Closed)

Created:
7 years, 7 months ago by Anton Muhin

Modified:
7 years, 6 months ago

Reviewers:
Andrei Mouravski, sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Verify that correct number of arguments was passed. R=amouravski@google.com Committed: https://code.google.com/p/dart/source/detail?r=23296

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -18 lines)			Patch
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View		5 chunks	+9 lines, -11 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/systemnative.py	View		2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

lgtm https://codereview.chromium.org/15850004/diff/1/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/15850004/diff/1/tools/dom/scripts/generator.py#newcode360 tools/dom/scripts/generator.py:360: def NumberOfRequiredInDart(self): Add a doc comment to this. ...

7 years, 6 months ago (2013-05-28 17:32:34 UTC) #2

Anton Muhin

https://codereview.chromium.org/15850004/diff/1/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/15850004/diff/1/tools/dom/scripts/generator.py#newcode360 tools/dom/scripts/generator.py:360: def NumberOfRequiredInDart(self): On 2013/05/28 17:32:34, Andrei Mouravski wrote: > ...

7 years, 6 months ago (2013-05-28 17:41:15 UTC) #3

Anton Muhin

7 years, 6 months ago (2013-05-28 17:42:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23296 (presubmit successful).

Expand Messages | Collapse Messages