Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 15844004: Fix deploy tests. (Closed)

Created:
7 years, 7 months ago by Bob Nystrom
Modified:
7 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, -270 lines) Patch
M sdk/lib/_internal/pub/lib/src/command_deploy.dart View 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/_internal/pub/test/deploy/compiles_dart_entrypoints_to_dart_and_js.dart View 1 chunk +0 lines, -46 lines 0 comments Download
A + sdk/lib/_internal/pub/test/deploy/compiles_dart_entrypoints_to_dart_and_js_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/_internal/pub/test/deploy/copies_dart_js_next_to_entrypoints.dart View 1 chunk +0 lines, -76 lines 0 comments Download
A + sdk/lib/_internal/pub/test/deploy/copies_dart_js_next_to_entrypoints_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/_internal/pub/test/deploy/copies_non_dart_files_to_deploy.dart View 1 chunk +0 lines, -43 lines 0 comments Download
A + sdk/lib/_internal/pub/test/deploy/copies_non_dart_files_to_deploy_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/_internal/pub/test/deploy/ignores_non_entrypoint_dart_files.dart View 1 chunk +0 lines, -44 lines 0 comments Download
A + sdk/lib/_internal/pub/test/deploy/ignores_non_entrypoint_dart_files_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/_internal/pub/test/deploy/reports_dart_parse_errors.dart View 1 chunk +0 lines, -45 lines 0 comments Download
A + sdk/lib/_internal/pub/test/deploy/reports_dart_parse_errors_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/_internal/pub/test/deploy/with_no_web_directory.dart View 1 chunk +0 lines, -19 lines 0 comments Download
A + sdk/lib/_internal/pub/test/deploy/with_no_web_directory_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
Since the test file names didn't end in "_test", they weren't being run. Oops! Found ...
7 years, 7 months ago (2013-05-23 16:49:06 UTC) #1
nweiz
lgtm
7 years, 7 months ago (2013-05-23 20:03:57 UTC) #2
Bob Nystrom
7 years, 7 months ago (2013-05-23 20:25:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23097 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698