Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 15842004: Support auto-drain of HttpRequest data. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen
Modified:
7 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support auto-drain of HttpRequest data. When headers of the HttpResponse are about to be sent, and the HttpRequest have not had any subscriber yet, drain the request body and then write the headers. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23228

Patch Set 1 #

Patch Set 2 : Add documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -40 lines) Patch
M sdk/lib/io/http.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 10 chunks +53 lines, -36 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/standalone/io/http_parser_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/standalone/io/http_server_response_test.dart View 2 chunks +29 lines, -0 lines 0 comments Download
M tests/standalone/io/http_session_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 7 months ago (2013-05-24 13:08:47 UTC) #1
Søren Gjesse
lgtm
7 years, 7 months ago (2013-05-24 13:52:25 UTC) #2
Anders Johnsen
7 years, 7 months ago (2013-05-27 15:43:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r23228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698