Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1583203003: Don't put spaces around magic generic method annotation comments. (Closed)

Created:
4 years, 11 months ago by Bob Nystrom
Modified:
4 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't put spaces around magic generic method annotation comments. Fix #477. R=jmesserly@google.com Committed: https://github.com/dart-lang/dart_style/commit/9efbfbaaa38253262fafd546e59b8d49f715bad9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -5 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/chunk_builder.dart View 6 chunks +26 lines, -5 lines 0 comments Download
A test/comments/generic_methods.unit View 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 11 months ago (2016-01-14 22:48:21 UTC) #2
Jennifer Messerly
LGTM, thank you!
4 years, 11 months ago (2016-01-14 22:50:55 UTC) #3
Bob Nystrom
4 years, 11 months ago (2016-01-14 23:10:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9efbfbaaa38253262fafd546e59b8d49f715bad9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698