Issue 15832003: Change File.directory to not do any IO

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15832003: Change File.directory to not do any IO (Closed)

Created:
7 years, 6 months ago by Søren Gjesse

Modified:
7 years, 6 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change File.directory to not do any IO Removed the File.directory and File.directorySync methods and added a File.directory getter. The File.directory getter does not do any IO, but just calculates the directory of the file from the path. R=whesse@google.com BUG=http://dartbug.com/9926 Committed: https://code.google.com/p/dart/source/detail?r=23349

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -279 lines)			Patch
M	runtime/bin/builtin_natives.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/file.h	View	2 chunks	+19 lines, -21 lines	0 comments	Download
M	runtime/bin/file.cc	View	3 chunks	+0 lines, -40 lines	0 comments	Download
M	runtime/bin/file_android.cc	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	runtime/bin/file_patch.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/file_win.cc	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/io_patch.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/io/file.dart	View	1 chunk	+2 lines, -11 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	2 chunks	+22 lines, -41 lines	0 comments	Download
M	tests/standalone/io/file_error_test.dart	View	2 chunks	+0 lines, -33 lines	0 comments	Download
M	tests/standalone/io/file_fuzz_test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/standalone/io/file_non_ascii_sync_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/file_non_ascii_test.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View	1 chunk	+16 lines, -30 lines	0 comments	Download
M	utils/compiler/create_snapshot.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years, 6 months ago (2013-05-29 12:38:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23349 (presubmit successful).

Expand Messages | Collapse Messages