Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 15831003: Revert "Allow ambiguous Expect and ExpectException imports." (Closed)

Created:
7 years, 7 months ago by floitsch
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org, Ivan Posva, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Revert "Allow ambiguous Expect and ExpectException imports." This reverts commit r18318. BUG= http://dartbug.com/8474 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=23147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java View 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
7 years, 7 months ago (2013-05-24 12:21:40 UTC) #1
Johnni Winther
lgtm
7 years, 7 months ago (2013-05-24 13:08:36 UTC) #2
floitsch
7 years, 7 months ago (2013-05-24 13:22:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23147 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698