Issue 15827006: Implement shift left on ARM and re-enable previously disabled test.

Issue 15827006: Implement shift left on ARM and re-enable previously disabled test. (Closed)

Created:
7 years, 6 months ago by regis

Modified:
7 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement shift left on ARM and re-enable previously disabled test. Fix bug on ia32 and x64. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=23307

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -13 lines)			Patch
M	runtime/tests/vm/vm.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	3 chunks	+128 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/15827006/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/15827006/diff/1/runtime/vm/intermediate_language_arm.cc#newcode2002 runtime/vm/intermediate_language_arm.cc:2002: while ((tmp >>= 1) != 0) { Could ...

7 years, 6 months ago (2013-05-28 19:43:32 UTC) #2

regis

Thanks! https://codereview.chromium.org/15827006/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/15827006/diff/1/runtime/vm/intermediate_language_arm.cc#newcode2002 runtime/vm/intermediate_language_arm.cc:2002: while ((tmp >>= 1) != 0) { On ...

7 years, 6 months ago (2013-05-28 21:10:15 UTC) #3

regis

7 years, 6 months ago (2013-05-28 21:10:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23307 (presubmit successful).

Expand Messages | Collapse Messages