Issue 15824005: More status file changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15824005: More status file changes. (Closed)

Created:
7 years, 6 months ago by ngeoffray

Modified:
7 years, 6 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More status file changes. Committed: https://code.google.com/p/dart/source/detail?r=23323

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	pkg/pkg.status	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Committed patchset #1 manually as r23323 (presubmit successful).

7 years, 6 months ago (2013-05-29 07:39:55 UTC) #2

ahe

7 years, 6 months ago (2013-05-29 08:21:12 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/15824005/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/15824005/diff/1/pkg/pkg.status#newcode123
pkg/pkg.status:123: unittest/test/unittest_test: Pass, Crash # Issue 10935
I don't think this is related to csp.

I see it all the time when testing on the Mac.  I think DRT is broken, and we're
switching to content shell instead.  Hopefully, that is more stable.

Expand Messages | Collapse Messages