Issue 15823008: Fix bug in VM timer implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15823008: Fix bug in VM timer implementation. (Closed)

Created:
7 years, 6 months ago by podivilov

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix bug in VM timer implementation. Timers stop working after exception in callback. R=floitsch@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23271

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
M	sdk/lib/io/timer_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/isolate.status	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
A +	tests/lib/async/run_async6_test.dart	View		1 chunk	+9 lines, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

floitsch

LGTM. Please close http://dartbug.com/9013, or update it. There are some tests that are currently marked ...

7 years, 6 months ago (2013-05-28 13:25:06 UTC) #3

podivilov

7 years, 6 months ago (2013-05-28 13:54:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r23271 (presubmit successful).