- Inline iterator calls made for a "for in".

- Inline iterator calls made for a "for in".
- Remove inlining restriction for recursive calls.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23253

[kasperl, 2013-05-28 10:31:34]

LGTM with a comment:

https://codereview.chromium.org/15818003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/15818003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:2472:
checkIfExposesThis(new TypedSelector(iteratorType, moveNextSelector));
If calling iterator doesn't expose 'this', how can calling moveNext or current
on the iterator expose it? At least add a comment.

[ngeoffray, 2013-05-28 10:41:38]

Thanks Kasper.

https://codereview.chromium.org/15818003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/15818003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:2472:
checkIfExposesThis(new TypedSelector(iteratorType, moveNextSelector));
On 2013/05/28 10:31:34, kasperl wrote:
> If calling iterator doesn't expose 'this', how can calling moveNext or current
> on the iterator expose it? At least add a comment.

Right now it won't, but we could refine the checkIfExposesThis method and be in
that situation.

But based on your suggestion, I will make it always expose this. Any reasonable
implementation of iterator should expose this.

[ngeoffray, 2013-05-28 11:40:19]

Kasper, could you PTAL? I improved the types used in a forin, to give the
correct type to the used field or variable.

[kasperl, 2013-05-28 11:48:40]

LGTM!

https://codereview.chromium.org/15818003/diff/16001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/15818003/diff/16001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:2477:
// this.
.... so we play it safe and assume it will.

[ngeoffray, 2013-05-28 11:50:48]

Committed patchset #3 manually as r23253 (presubmit successful).

[ngeoffray, 2013-05-28 11:50:57]

Thanks Kasper.

https://codereview.chromium.org/15818003/diff/16001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/15818003/diff/16001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:2477:
// this.
On 2013/05/28 11:48:40, kasperl wrote:
> .... so we play it safe and assume it will.

Done.