Issue 15810007: Updating Clipboard.setDragImage to accept elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15810007: Updating Clipboard.setDragImage to accept elements. (Closed)

Created:
7 years, 6 months ago by blois

Modified:
7 years, 6 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Updating Clipboard.setDragImage to accept elements. This changes the IDL to expose it, but the method is custom in V8 and needs to be custom in Dart. Basically the spec has changed that setDragImage should accept elements rather than just images: http://www.w3.org/html/wg/drafts/html/master/editing.html#dom-datatransfer-setdragimage And V8 (and Firefox) already support this: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/v8/custom/V8ClipboardCustom.cpp&sq=package:chromium&type=cs&l=80&rcl=1369903032 Also, this appears to already have the Dartium code for it- http://src.chromium.org/multivm/trunk/webkit/Source/bindings/dart/custom/DartClipboardCustom.cpp Not sure if there are additional changes, but this appears to work for me (requires manual testing). BUG=10819 R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=23568

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

blois

7 years, 6 months ago (2013-06-03 21:09:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r23568 (presubmit successful).