Issue 15810006: Reapply removeWhere and retainWhere for elements in dart:html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15810006: Reapply removeWhere and retainWhere for elements in dart:html (Closed)

Created:
7 years, 6 months ago by Emily Fortuna

Modified:
7 years, 6 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply removeWhere and retainWhere for elements in dart:html BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=23371

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -0 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	tests/html/element_test.dart	View	1 chunk	+44 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+18 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm, with nit. https://codereview.chromium.org/15810006/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/15810006/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode70 tools/dom/templates/html/impl/impl_Element.darttemplate:70: Iterable removed = []; var removed; ...

7 years, 6 months ago (2013-05-29 23:10:49 UTC) #2

Emily Fortuna

7 years, 6 months ago (2013-05-29 23:40:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r23371 (presubmit successful).

Expand Messages | Collapse Messages