Issue 15808015: Fixing dart2js KeyEvent issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15808015: Fixing dart2js KeyEvent issue. (Closed)

Created:
7 years, 6 months ago by blois

Modified:
7 years, 6 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixing dart2js KeyEvent issue. The incorrect type for the JS call was causing the compiler to generate incorrect code. BUG=11088 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=23659

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
		sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
		tools/dom/src/dart2js_KeyEvent.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Emily Fortuna

Can you try re-uploading this patch set? I get "chunk mismatch" message and can't see ...

7 years, 6 months ago (2013-06-05 20:17:14 UTC) #2

Emily Fortuna

actually, if it's the same as the diff in the email, lgtm

7 years, 6 months ago (2013-06-05 20:17:51 UTC) #3

blois

7 years, 6 months ago (2013-06-05 21:11:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r23659 (presubmit successful).