Issue 15797007: Report CompileTimeErrorCode for 'const' argument mismatch.

Issue 15797007: Report CompileTimeErrorCode for 'const' argument mismatch. (Closed)

Created:
7 years, 6 months ago by scheglov

Modified:
7 years, 6 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report CompileTimeErrorCode for 'const' argument mismatch. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23374

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -23 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	3 chunks	+34 lines, -0 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View	8 chunks	+28 lines, -17 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	3 chunks	+39 lines, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/15797007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java (right): https://codereview.chromium.org/15797007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java#newcode833 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:833: NOT_ENOUGH_REQUIRED_ARGUMENTS("%d required argument(s) expected, but only %d found"), ...

7 years, 6 months ago (2013-05-29 21:36:33 UTC) #2

jwren

On 2013/05/29 21:36:33, Brian Wilkerson wrote: > LGTM > > https://codereview.chromium.org/15797007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java > File > editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java ...

7 years, 6 months ago (2013-05-29 21:45:22 UTC) #3

scheglov

Committed patchset #1 manually as r23374 (presubmit successful).

7 years, 6 months ago (2013-05-30 01:23:09 UTC) #4

scheglov

7 years, 6 months ago (2013-05-30 01:23:53 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/15797007/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
(right):

https://codereview.chromium.org/15797007/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:833:
NOT_ENOUGH_REQUIRED_ARGUMENTS("%d required argument(s) expected, but only %d
found"),
On 2013/05/29 21:36:33, Brian Wilkerson wrote:
> nit: The message will read better when there are no required parameters if we
> remove the word "only" (there's another error/warning with the same problem
that
> I noticed this morning, which is why I noticed this).

Fixed here and in SWC.

Expand Messages | Collapse Messages