Issue 15796003: Include Platform.envrironment in pub, when passing custom environment option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15796003: Include Platform.envrironment in pub, when passing custom environment option. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
nweiz, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Include Platform.envrironment in pub, when passing custom environment option. BUG= Committed: https://code.google.com/p/dart/source/detail?r=23149

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

		Unified diffs	Side-by-side diffs	Stats (+8 lines, -1 line)
	M	sdk/lib/_internal/pub/lib/src/io.dart	View	1 chunk	+8 lines, -1 line	2 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r23149 (presubmit successful).

7 years, 7 months ago (2013-05-24 14:03:07 UTC) #2

nweiz

7 years, 6 months ago (2013-05-28 18:32:31 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/15796003/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/15796003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:598: environment.forEach((key, value) =>
env[key] = value);
Use mapAddAll from utils.dart.

https://codereview.chromium.org/15796003/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:600: 
extra newline

Expand Messages | Collapse Messages