Try to send EndStreamFlag together with headers (if possible)

Try to send EndStreamFlag together with headers (if possible)

Some servers (e.g. https://twitter.com) will respond with "status: 400" if one
doesn't send the EOS flag with the headers frame (it's not a protocol violation,
since it responds with a valid "status: 400" response, but it still different
than what other servers, like GWS do).

R=sgjesse@google.com

Committed: https://github.com/dart-lang/http2/commit/e7945fb62cf9d1cb59116a056123ad47f3899d83

[kustermann, 2016-01-11 11:59:13]

kustermann@google.com changed reviewers:
+ sgjesse@google.com

[Søren Gjesse, 2016-01-11 14:26:35]

LGTM

https://codereview.chromium.org/1578753002/diff/20001/test/client_websites_te...
File test/client_websites_test.dart (right):

https://codereview.chromium.org/1578753002/diff/20001/test/client_websites_te...
test/client_websites_test.dart:127: } else if
(response.headers['content-encoding']?.join('') == 'deflate') {
Separate change from what is in the description?

[kustermann, 2016-01-11 15:08:33]

Thank you.

https://codereview.chromium.org/1578753002/diff/20001/test/client_websites_te...
File test/client_websites_test.dart (right):

https://codereview.chromium.org/1578753002/diff/20001/test/client_websites_te...
test/client_websites_test.dart:127: } else if
(response.headers['content-encoding']?.join('') == 'deflate') {
On 2016/01/11 14:26:35, Søren Gjesse wrote:
> Separate change from what is in the description?

There is a test for twitter.com in this file, and it responds with a deflate
encoded body. So I can make the test pass by moving the EndOfStream flag to the
HeaderFrame and add decoding support for deflate.

[kustermann, 2016-01-11 15:08:43]

Description was changed from

==========
Try to send EndStreamFlag together with headers (if possible)

Some servers (e.g. https://twitter.com) will respond with "status: 400" if one
doesn't send the EOS flag with the headers frame (it's not a protocol violation,
since it responds with a valid "status: 400" response, but it still different
than what other servers, like GWS do).
==========

to

==========
Try to send EndStreamFlag together with headers (if possible)

Some servers (e.g. https://twitter.com) will respond with "status: 400" if one
doesn't send the EOS flag with the headers frame (it's not a protocol violation,
since it responds with a valid "status: 400" response, but it still different
than what other servers, like GWS do).

R=sgjesse@google.com

Committed:
https://github.com/dart-lang/http2/commit/e7945fb62cf9d1cb59116a056123ad47f38...
==========

[kustermann, 2016-01-11 15:08:44]

Committed patchset #2 (id:20001) manually as
e7945fb62cf9d1cb59116a056123ad47f3899d83 (presubmit successful).