Issue 15782006: Allow safari to do pop ups on startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15782006: Allow safari to do pop ups on startup (Closed)

Created:
7 years, 6 months ago by ricow1

Modified:
7 years, 6 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allow safari to do pop ups on startup R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=23287

Patch Set 2 : #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -11 lines)			Patch
	M	tools/testing/dart/browser_controller.dart	View	1	2 chunks	+32 lines, -11 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/15782006/diff/2001/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/15782006/diff/2001/tools/testing/dart/browser_controller.dart#newcode205 tools/testing/dart/browser_controller.dart:205: "com.apple.Safari.ContentPageGroupIdentifier." // No , What is this "// ...

7 years, 6 months ago (2013-05-28 15:07:52 UTC) #2

ricow1

7 years, 6 months ago (2013-05-28 15:37:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r23287 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15782006: Allow safari to do pop ups on startup (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages