Find “browser” dependency even if it’s dev or override.

Find “browser” dependency even if it’s dev or override.

BUG=https://code.google.com/p/dart/issues/detail?id=16617
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32523

[nweiz, 2014-02-10 21:42:00]

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
File
sdk/lib/_internal/pub/test/build/copies_browser_js_with_dependency_override_test.dart
(right):

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/copies_browser_js_with_dependency_override_test.dart:16:
integration("compiles dart.js and interop.js next to entrypoints", () {
Update the test name to match the file name.

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/copies_browser_js_with_dependency_override_test.dart:26:
"dev_dependencies": {
The file name indicates that this is testing dependency overrides, not dev
dependencies.

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
File
sdk/lib/_internal/pub/test/build/copies_browser_js_with_dev_dependency_test.dart
(right):

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/copies_browser_js_with_dev_dependency_test.dart:16:
integration("compiles dart.js and interop.js next to entrypoints", () {
Update the test name to match the file name.

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
File sdk/lib/_internal/pub/test/build/utils.dart (right):

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/utils.dart:10: void serveBrowserPackage() {
I'm not a huge fan of the pattern of scattering these utility methods all over
the test directory. I'd rather see this in the standard test_pub.dart.

Regardless of what you decide to do there, document it.

[Bob Nystrom, 2014-02-10 22:08:18]

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
File
sdk/lib/_internal/pub/test/build/copies_browser_js_with_dependency_override_test.dart
(right):

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/copies_browser_js_with_dependency_override_test.dart:16:
integration("compiles dart.js and interop.js next to entrypoints", () {
On 2014/02/10 21:42:00, nweiz wrote:
> Update the test name to match the file name.

Done.

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/copies_browser_js_with_dependency_override_test.dart:26:
"dev_dependencies": {
On 2014/02/10 21:42:00, nweiz wrote:
> The file name indicates that this is testing dependency overrides, not dev
> dependencies.

Ugh. Oops. Fixed.

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
File
sdk/lib/_internal/pub/test/build/copies_browser_js_with_dev_dependency_test.dart
(right):

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/copies_browser_js_with_dev_dependency_test.dart:16:
integration("compiles dart.js and interop.js next to entrypoints", () {
On 2014/02/10 21:42:00, nweiz wrote:
> Update the test name to match the file name.

Done.

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
File sdk/lib/_internal/pub/test/build/utils.dart (right):

https://codereview.chromium.org/157743005/diff/1/sdk/lib/_internal/pub/test/b...
sdk/lib/_internal/pub/test/build/utils.dart:10: void serveBrowserPackage() {
On 2014/02/10 21:42:00, nweiz wrote:
> I'm not a huge fan of the pattern of scattering these utility methods all over
> the test directory. I'd rather see this in the standard test_pub.dart.

I actually prefer more tightly scoped files. test_pub is getting to be a pretty
big bag of mixed nuts.

> Regardless of what you decide to do there, document it.

Done.

[nweiz, 2014-02-10 22:42:21]

lgtm

[Bob Nystrom, 2014-02-10 23:25:01]

Committed patchset #2 manually as r32523 (presubmit successful).