Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1576853003: Deprecate the ChainHandler typedef. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stack_trace@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/src/chain.dart View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M lib/src/stack_zone_specification.dart View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
nweiz
4 years, 11 months ago (2016-01-12 01:09:50 UTC) #1
Bob Nystrom
https://codereview.chromium.org/1576853003/diff/1/lib/src/chain.dart File lib/src/chain.dart (right): https://codereview.chromium.org/1576853003/diff/1/lib/src/chain.dart#newcode17 lib/src/chain.dart:17: @deprecated( Remove "(". https://codereview.chromium.org/1576853003/diff/1/lib/src/frame.dart File lib/src/frame.dart (right): https://codereview.chromium.org/1576853003/diff/1/lib/src/frame.dart#newcode308 lib/src/frame.dart:308: ...
4 years, 11 months ago (2016-01-12 01:12:14 UTC) #2
nweiz
Code review changes
4 years, 11 months ago (2016-01-12 01:23:05 UTC) #3
nweiz
Was simultaneously working on two patches and a blog post and this got messed up. ...
4 years, 11 months ago (2016-01-12 01:30:35 UTC) #4
Bob Nystrom
lgtm
4 years, 11 months ago (2016-01-12 16:53:03 UTC) #5
nweiz
4 years, 11 months ago (2016-01-12 19:39:02 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
474f3aba1c62d5ecfbcec5dcff1aeee50c528415 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698