Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Issue 15763006: Issue 10091. Type literal is a constant. (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java View 2 chunks +3 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java View 1 chunk +16 lines, -0 lines 0 comments Download
M tests/co19/co19-analyzer.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 7 months ago (2013-05-23 21:21:25 UTC) #1
Brian Wilkerson
LGTM
7 years, 7 months ago (2013-05-23 21:42:56 UTC) #2
scheglov
7 years, 7 months ago (2013-05-23 23:15:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698