Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 157593003: Improve constant propagation for type arguments. (Closed)

Created:
6 years, 10 months ago by Florian Schneider
Modified:
6 years, 10 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis
Visibility:
Public.

Description

Improve constant propagation for type arguments. The instruction to extract type arguments are now fully supported in constant propagation. I also added cid-information to non-instance constants (like e.g. type arguments). This will enable more opportunities for allocation sinking because it requires the type arguments to be known constant. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=32489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
6 years, 10 months ago (2014-02-10 10:02:28 UTC) #1
srdjan
lgtm
6 years, 10 months ago (2014-02-10 10:10:07 UTC) #2
Florian Schneider
6 years, 10 months ago (2014-02-10 10:30:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698