Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 15759011: Type check field initializers. (Closed)

Created:
7 years, 6 months ago by Johnni Winther
Modified:
7 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Change indentation. #

Patch Set 3 : Test added. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -23 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 1 chunk +7 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 1 chunk +27 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 2 4 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Johnni Winther
7 years, 6 months ago (2013-05-31 19:18:16 UTC) #1
karlklose
Could you add tests to the typechecker-test too?
7 years, 6 months ago (2013-06-03 11:50:10 UTC) #2
Johnni Winther
On 2013/06/03 11:50:10, karlklose wrote: > Could you add tests to the typechecker-test too? Done. ...
7 years, 6 months ago (2013-06-03 13:47:36 UTC) #3
karlklose
LGTM.
7 years, 6 months ago (2013-06-06 12:15:31 UTC) #4
Johnni Winther
7 years, 6 months ago (2013-06-07 06:39:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r23725 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698