Switch from DRT to content shell.

Switch from DRT to content shell.

R=kustermann@google.com, ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23328

[ricow1, 2013-05-27 16:51:59]

I will do a thorough review tomorrow morning.
We need to coordinate this since we also need to update the scripts inside
tools/bots/ (annotated steps) and the archiving logic that we use for the editor
builders client/tools/buildbot_annotated_steps.py 


Cheers,
Rico

https://codereview.chromium.org/15755017/diff/1/pkg/unittest/lib/test_control...
File pkg/unittest/lib/test_controller.js (right):

https://codereview.chromium.org/15755017/diff/1/pkg/unittest/lib/test_control...
pkg/unittest/lib/test_controller.js:30: // testRunner is provided by DRT or
WebKit's layout tests.
DRT -> content shell

https://codereview.chromium.org/15755017/diff/1/tools/testing/dart/drt_update...
File tools/testing/dart/drt_updater.dart (right):

https://codereview.chromium.org/15755017/diff/1/tools/testing/dart/drt_update...
tools/testing/dart/drt_updater.dart:1: // Copyright (c) 2012, the Dart project
authors.  Please see the AUTHORS file
we should rename this file

[kustermann, 2013-05-28 08:17:45]

tool/testing/dart/* lgtm.

https://codereview.chromium.org/15755017/diff/1/tools/testing/drt-trampoline.py
File tools/testing/drt-trampoline.py (right):

https://codereview.chromium.org/15755017/diff/1/tools/testing/drt-trampoline....
tools/testing/drt-trampoline.py:1: # Copyright (c) 2011, the Dart project
authors.  Please see the AUTHORS file
We should be able to remove this file. test.py no longer uses drt-trampoline.py

https://codereview.chromium.org/15755017/diff/1/tools/testing/legpad/legpad.py
File tools/testing/legpad/legpad.py (right):

https://codereview.chromium.org/15755017/diff/1/tools/testing/legpad/legpad.p...
tools/testing/legpad/legpad.py:8: Legpad is used to compile .dart files to
javascript, using the dart2js compiler.
Kasper/ricow said this is no longer used. So we can remove this file.

[ricow1, 2013-05-28 08:21:39]

As Martin said, tools/* lgtm.

https://codereview.chromium.org/15755017/diff/1/tools/testing/dart/test_optio...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/15755017/diff/1/tools/testing/dart/test_optio...
tools/testing/dart/test_options.dart:256: 'drt', // TODO(antonm): fix the option
name.
As stated otherwhere, we need to coordinate this update to update the annotated
steps (we basically extract the runtime from the bot name!)

https://codereview.chromium.org/15755017/diff/1/tools/testing/legpad/legpad.py
File tools/testing/legpad/legpad.py (right):

https://codereview.chromium.org/15755017/diff/1/tools/testing/legpad/legpad.p...
tools/testing/legpad/legpad.py:8: Legpad is used to compile .dart files to
javascript, using the dart2js compiler.
On 2013/05/28 08:17:45, kustermann wrote:
> Kasper/ricow said this is no longer used. So we can remove this file.
s/file/full directory

[ahe, 2013-05-28 11:52:11]

I noticed a problem with this on Mac.  When you copy-and-paste the command lines
to reproduce a test failure, the command isn't quoted.  This is a problem as its
name contains several spaces:

Command line: /Users/ahe/Dart/all/dart//client/tests/drt/Content
Shell.app/Contents/MacOS/Content Shell "--no-timeout" "--dump-render-tree"
"http://127.0.0.1:61492/root_build/generated_tests/dart2js-drt/tests_html_shadow_dom_layout_test/test.html?crossOriginPort=61493"

[Anton Muhin, 2013-05-28 16:07:58]

https://codereview.chromium.org/15755017/diff/1/pkg/unittest/lib/test_control...
File pkg/unittest/lib/test_controller.js (right):

https://codereview.chromium.org/15755017/diff/1/pkg/unittest/lib/test_control...
pkg/unittest/lib/test_controller.js:30: // testRunner is provided by DRT or
WebKit's layout tests.
On 2013/05/27 16:51:59, ricow1 wrote:
> DRT -> content shell

Done.

https://codereview.chromium.org/15755017/diff/1/tools/testing/dart/drt_update...
File tools/testing/dart/drt_updater.dart (right):

https://codereview.chromium.org/15755017/diff/1/tools/testing/dart/drt_update...
tools/testing/dart/drt_updater.dart:1: // Copyright (c) 2012, the Dart project
authors.  Please see the AUTHORS file
On 2013/05/27 16:51:59, ricow1 wrote:
> we should rename this file

Yes, as many options. let me add a todo for now.

https://codereview.chromium.org/15755017/diff/1/tools/testing/dart/test_optio...
File tools/testing/dart/test_options.dart (right):

https://codereview.chromium.org/15755017/diff/1/tools/testing/dart/test_optio...
tools/testing/dart/test_options.dart:256: 'drt', // TODO(antonm): fix the option
name.
On 2013/05/28 08:21:39, ricow1 wrote:
> As stated otherwhere, we need to coordinate this update to update the
annotated
> steps (we basically extract the runtime from the bot name!)

Yes.

https://codereview.chromium.org/15755017/diff/1/tools/testing/drt-trampoline.py
File tools/testing/drt-trampoline.py (right):

https://codereview.chromium.org/15755017/diff/1/tools/testing/drt-trampoline....
tools/testing/drt-trampoline.py:1: # Copyright (c) 2011, the Dart project
authors.  Please see the AUTHORS file
On 2013/05/28 08:17:45, kustermann wrote:
> We should be able to remove this file. test.py no longer uses
drt-trampoline.py

Agree, I thought about it as well, let me create a separate CL for it.

https://codereview.chromium.org/15755017/diff/1/tools/testing/legpad/legpad.py
File tools/testing/legpad/legpad.py (right):

https://codereview.chromium.org/15755017/diff/1/tools/testing/legpad/legpad.p...
tools/testing/legpad/legpad.py:8: Legpad is used to compile .dart files to
javascript, using the dart2js compiler.
On 2013/05/28 08:21:39, ricow1 wrote:
> On 2013/05/28 08:17:45, kustermann wrote:
> > Kasper/ricow said this is no longer used. So we can remove this file.
> s/file/full directory
> 

Ditto, separate CL.

[Anton Muhin, 2013-05-29 08:35:08]

Committed patchset #3 manually as r23328 (presubmit successful).