Change output of string equality match failures.

Change output of string equality match failures.
See https://code.google.com/p/dart/issues/detail?id=9827

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23604

[Siggi Cherem (dart-lang), 2013-05-22 23:09:42]

lgtm, with minor request

https://codereview.chromium.org/15755005/diff/1/pkg/unittest/test/matchers_te...
File pkg/unittest/test/matchers_test.dart (right):

https://codereview.chromium.org/15755005/diff/1/pkg/unittest/test/matchers_te...
pkg/unittest/test/matchers_test.dart:603: "Expected: Y But was: XX ^ Differ at
position 0. Actual: 'X'",
I assume some \n and spaces are trimmed here? it would be good to test that the
output is actually aligned correctly

[Siggi Cherem (dart-lang), 2013-05-23 00:43:47]

https://codereview.chromium.org/15755005/diff/5001/pkg/unittest/lib/src/basem...
File pkg/unittest/lib/src/basematcher.dart (right):

https://codereview.chromium.org/15755005/diff/5001/pkg/unittest/lib/src/basem...
pkg/unittest/lib/src/basematcher.dart:38: bool includeActual(reason) =>
!reason.toString().startsWith('was ');
2 comments:
a) how about storing a boolean property in your matcher instead? In the end it
is the same instance of this class that will print the mismatch.


b) rename to phrase it as a question or a statement. Ideas:
 - "includesActual" (see the extra 's'), which would mean the opposite of what
your method currently does.
 - "shouldIncludeActual"

I prefer the former, since it better represents a property of this object.

[gram, 2013-06-01 00:36:54]

PTAL

I took out the test for whether to show the actual value. We now do it
regardless, which leads to a lot of duplication, but there was no good solution.


I'll try come up with a better solution later, by only showing the But: part if
it adds value over the actual value.

[Siggi Cherem (dart-lang), 2013-06-02 19:34:05]

lgtm

[gram, 2013-06-03 23:25:39]

PTAL - I added a test file from the scheduled test package.

[Siggi Cherem (dart-lang), 2013-06-04 15:45:29]

lgtm

https://codereview.chromium.org/15755005/diff/15001/pkg/scheduled_test/test/d...
File pkg/scheduled_test/test/descriptor/file_test.dart (right):

https://codereview.chromium.org/15755005/diff/15001/pkg/scheduled_test/test/d...
pkg/scheduled_test/test/descriptor/file_test.dart:232: "Expected: contains
'baaz'\n     But: was 'barfoobaz'.\nActual: 'barfoobaz'"
80 col

[gram, 2013-06-04 17:17:59]

Committed patchset #5 manually as r23604 (presubmit successful).