Issue 157453002: Fix dartium build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 157453002: Fix dartium build. (Closed)

Created:
6 years, 10 months ago by Johnni Winther

Modified:
6 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dartium build. BUG= Committed: https://code.google.com/p/dart/source/detail?r=32417

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	tests/lib/lib.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tests/lib/mirrors/mirrors_reader_test.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

TBR https://codereview.chromium.org/157453002/diff/1/tests/lib/mirrors/mirrors_reader_test.dart File tests/lib/mirrors/mirrors_reader_test.dart (right): https://codereview.chromium.org/157453002/diff/1/tests/lib/mirrors/mirrors_reader_test.dart#newcode47 tests/lib/mirrors/mirrors_reader_test.dart:47: void main([List<String> arguments = const <String>[]]) { Dartium ...

6 years, 10 months ago (2014-02-07 11:11:02 UTC) #1

Johnni Winther

Committed patchset #1 manually as r32417 (presubmit successful).

6 years, 10 months ago (2014-02-07 11:12:10 UTC) #2

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages