Issue 15745024: Fix bug in Expect package's string compare.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15745024: Fix bug in Expect package's string compare. (Closed)

Created:
7 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 6 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bug in Expect package's string compare. Committed: https://code.google.com/p/dart/source/detail?r=23455

Patch Set 1 #

Total comments: 4

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	pkg/expect/lib/expect.dart	View		4 chunks	+3 lines, -1 line	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as r23455 (presubmit successful).

7 years, 6 months ago (2013-05-31 07:56:26 UTC) #1

kasperl

https://codereview.chromium.org/15745024/diff/1/pkg/expect/lib/expect.dart File pkg/expect/lib/expect.dart (right): https://codereview.chromium.org/15745024/diff/1/pkg/expect/lib/expect.dart#newcode32 pkg/expect/lib/expect.dart:32: print("$string: $start: $end: $length"); Did you really mean to ...

7 years, 6 months ago (2013-05-31 08:14:22 UTC) #3

kasperl

7 years, 6 months ago (2013-05-31 08:28:30 UTC) #4

Message was sent while issue was closed.

LGTM with comments:

https://codereview.chromium.org/15745024/diff/1/pkg/expect/lib/expect.dart
File pkg/expect/lib/expect.dart (right):

https://codereview.chromium.org/15745024/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:32: print("$string: $start: $end: $length");
Remove printing.

https://codereview.chromium.org/15745024/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:69: * only a slice  containing the first difference
will be shown.
Remove one space after slice.

https://codereview.chromium.org/15745024/diff/1/pkg/expect/lib/expect.dart#ne...
pkg/expect/lib/expect.dart:72: print("digg: $expected, $actual");
Remove printing.

Expand Messages | Collapse Messages