Issue 15745013: Report parameters/arguments count mismatch

Issue 15745013: Report parameters/arguments count mismatch (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report parameters/arguments count mismatch https://code.google.com/p/dart/issues/detail?id=10108 https://code.google.com/p/dart/issues/detail?id=10302 https://code.google.com/p/dart/issues/detail?id=10494 R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23039

Patch Set 1 #

Total comments: 4

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -28 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java	View	3 chunks	+25 lines, -0 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View	2 chunks	+20 lines, -6 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/element/ElementFactory.java	View	1 chunk	+24 lines, -8 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	3 chunks	+12 lines, -9 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java	View	3 chunks	+36 lines, -0 lines	2 comments	Download
M	tests/co19/co19-analyzer.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jwren

https://codereview.chromium.org/15745013/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java (right): https://codereview.chromium.org/15745013/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java#newcode172 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java:172: EXTRA_POSITIONAL_ARGUMENTS("%s positional arguments expected, but %s found"), Numbers can ...

7 years, 7 months ago (2013-05-22 19:03:16 UTC) #2

scheglov

Committed patchset #1 manually as r23039 (presubmit successful).

7 years, 7 months ago (2013-05-22 19:36:59 UTC) #5

scheglov

7 years, 7 months ago (2013-05-22 19:37:31 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/15745013/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java
(right):

https://codereview.chromium.org/15745013/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java:172:
EXTRA_POSITIONAL_ARGUMENTS("%s positional arguments expected, but %s found"),
On 2013/05/22 19:03:16, jwren wrote:
> Numbers can be substituted with %d, instead of %s, same below

Done.

https://codereview.chromium.org/15745013/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java
(right):

https://codereview.chromium.org/15745013/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java:490:
// TODO(scheglov)
On 2013/05/22 19:03:16, jwren wrote:
> Did you mean to include the TODO in the CL?

Thank you, removed.

Expand Messages | Collapse Messages