Issue 15744017: Make int a double in argument type checks.

Issue 15744017: Make int a double in argument type checks. (Closed)

Created:
7 years, 7 months ago by karlklose

Modified:
7 years, 7 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make int a double in argument type checks. BUG=dartbug.com/10841 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=23139

Patch Set 2 : Status file update. #

Patch Set 4 : Make interceptor implement double. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_number.dart	View	1 2 3	1 chunk	+8 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/native_helper.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM, with one comment https://codereview.chromium.org/15744017/diff/5001/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/15744017/diff/5001/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1618 sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1618: if (cls == backend.jsIntClass) { ...

7 years, 7 months ago (2013-05-24 09:34:28 UTC) #2

karlklose

Thanks, Nicolas. https://codereview.chromium.org/15744017/diff/5001/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/15744017/diff/5001/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1618 sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1618: if (cls == backend.jsIntClass) { On 2013/05/24 ...

7 years, 7 months ago (2013-05-24 11:10:50 UTC) #3

karlklose

7 years, 7 months ago (2013-05-24 12:38:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r23139 (presubmit successful).

Expand Messages | Collapse Messages