Update browser controller and unittest lib to use start marker to figure out when to start new test…

Update browser controller and unittest lib to use start marker to figure out when to start new tests (and send back the correct id)

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23059

[kustermann, 2013-05-22 17:08:50]

https://codereview.chromium.org/15742006/diff/1/pkg/unittest/lib/test_control...
File pkg/unittest/lib/test_controller.js (right):

https://codereview.chromium.org/15742006/diff/1/pkg/unittest/lib/test_control...
pkg/unittest/lib/test_controller.js:36: function start() {
For symmetry reasons, I'd call it 'notifyStart()'.

https://codereview.chromium.org/15742006/diff/1/pkg/unittest/lib/test_control...
pkg/unittest/lib/test_controller.js:60: start();
When we reach this point, the test has already been executed. See on the line
150.
Please send the start message before calling main().

https://codereview.chromium.org/15742006/diff/1/tools/testing/dart/browser_co...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/15742006/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:618: var did_start = false;
I think you're on an old revision. Could you rebase on top of TOT? (With this
change, you can probably remove the hashtable ...)

[ricow1, 2013-05-22 17:36:11]

https://codereview.chromium.org/15742006/diff/1/pkg/unittest/lib/test_control...
File pkg/unittest/lib/test_controller.js (right):

https://codereview.chromium.org/15742006/diff/1/pkg/unittest/lib/test_control...
pkg/unittest/lib/test_controller.js:36: function start() {
On 2013/05/22 17:08:50, kustermann wrote:
> For symmetry reasons, I'd call it 'notifyStart()'.

Done.

https://codereview.chromium.org/15742006/diff/1/pkg/unittest/lib/test_control...
pkg/unittest/lib/test_controller.js:60: start();
On 2013/05/22 17:08:50, kustermann wrote:
> When we reach this point, the test has already been executed. See on the line
> 150.
> Please send the start message before calling main().
That is fine, we do 2 postmessage there, they will queue up

https://codereview.chromium.org/15742006/diff/1/tools/testing/dart/browser_co...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/15742006/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:618: var did_start = false;
On 2013/05/22 17:08:50, kustermann wrote:
> I think you're on an old revision. Could you rebase on top of TOT? (With this
> change, you can probably remove the hashtable ...)
did not know that landed, done

[ricow1, 2013-05-22 17:36:12]

https://codereview.chromium.org/15742006/diff/1/pkg/unittest/lib/test_control...
File pkg/unittest/lib/test_controller.js (right):

https://codereview.chromium.org/15742006/diff/1/pkg/unittest/lib/test_control...
pkg/unittest/lib/test_controller.js:36: function start() {
On 2013/05/22 17:08:50, kustermann wrote:
> For symmetry reasons, I'd call it 'notifyStart()'.

Done.

https://codereview.chromium.org/15742006/diff/1/pkg/unittest/lib/test_control...
pkg/unittest/lib/test_controller.js:60: start();
On 2013/05/22 17:08:50, kustermann wrote:
> When we reach this point, the test has already been executed. See on the line
> 150.
> Please send the start message before calling main().
That is fine, we do 2 postmessage there, they will queue up

https://codereview.chromium.org/15742006/diff/1/tools/testing/dart/browser_co...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/15742006/diff/1/tools/testing/dart/browser_co...
tools/testing/dart/browser_controller.dart:618: var did_start = false;
On 2013/05/22 17:08:50, kustermann wrote:
> I think you're on an old revision. Could you rebase on top of TOT? (With this
> change, you can probably remove the hashtable ...)
did not know that landed, done

[ricow1, 2013-05-23 08:37:02]

PTAL

[kustermann, 2013-05-23 09:26:38]

lgtm

(Tough I've to say that it's hard to understand the JavaScript part)

[ricow1, 2013-05-23 11:06:51]

Committed patchset #4 manually as r23059 (presubmit successful).