Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 15741021: Get deploy tests working on Windows. (Closed)

Created:
7 years, 7 months ago by Bob Nystrom
Modified:
7 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get deploy tests working on Windows. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=23105

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
Bob Nystrom
Now that they are actually enabled, the deploy tests are failing on Windows because of ...
7 years, 7 months ago (2013-05-23 20:50:57 UTC) #1
nweiz
Rather than replacing "|" with the platform separator, why not just replace "/"? That makes ...
7 years, 7 months ago (2013-05-23 20:52:50 UTC) #2
nweiz
On 2013/05/23 20:52:50, nweiz wrote: > Rather than replacing "|" with the platform separator, why ...
7 years, 7 months ago (2013-05-23 20:53:19 UTC) #3
Bob Nystrom
On 2013/05/23 20:53:19, nweiz wrote: > On 2013/05/23 20:52:50, nweiz wrote: > > Rather than ...
7 years, 7 months ago (2013-05-23 21:02:34 UTC) #4
Bob Nystrom
7 years, 7 months ago (2013-05-23 21:02:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r23105 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698