Issue 15741006: Add chromeOnAndroid support to the buildbot annotated steps scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15741006: Add chromeOnAndroid support to the buildbot annotated steps scripts. (Closed)

Created:
7 years, 7 months ago by kustermann

Modified:
7 years, 7 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add chromeOnAndroid support to the buildbot annotated steps scripts. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=23029

Patch Set 2 : Add android tools to PATH #

Total comments: 1

Patch Set 3 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -8 lines)			Patch
M	tools/bots/bot.py	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/bots/compiler.py	View	1	5 chunks	+33 lines, -3 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM with question https://codereview.chromium.org/15741006/diff/1003/tools/bots/compiler.py File tools/bots/compiler.py (right): https://codereview.chromium.org/15741006/diff/1003/tools/bots/compiler.py#newcode320 tools/bots/compiler.py:320: os.environ['PATH'] = os.pathsep.join( when we spawn ...

7 years, 7 months ago (2013-05-22 16:33:29 UTC) #4

kustermann

7 years, 7 months ago (2013-05-22 17:10:01 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r23029 (presubmit successful).